[
https://issues.apache.org/jira/browse/LUCENE-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405992#comment-16405992
]
Adrien Grand commented on LUCENE-8008:
--------------------------------------
Sorry I noticed this morning that I inadvertently pushed unrelated changes in
the above commit. I just reverted. Fortunately, they didn't make it to any
release.
> reduce/remove usages of CheckHits.EXPLAIN_TOLERANCE_*
> -----------------------------------------------------
>
> Key: LUCENE-8008
> URL: https://issues.apache.org/jira/browse/LUCENE-8008
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
> Priority: Major
> Fix For: master (8.0)
>
> Attachments: LUCENE-8008.patch
>
>
> these tolerance deltas are being (ab)used in various ways in tests. I did
> some experimentation and they can almost be removed entirely without too much
> pain.
> LUCENE-7997 fixes all similarities such that score() == explain(). It makes
> its possible to actually debug numeric errors and we need to do that if we
> have optimizations such as maxscore that care about score values. So I think
> we should do the same thing elsewhere in scoring (weight/scorer).
> We should at the very least fix tests (such as expression tests) that no
> longer need these deltas and can now assert exact values.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
