[
https://issues.apache.org/jira/browse/LUCENE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406135#comment-16406135
]
Alan Woodward commented on LUCENE-8202:
---------------------------------------
Updated patch, which I think should address all of Adrien's concerns.
{quote}advanceStack runs in quadratic time with shingleSize
{quote}
I don't think it does? The inner loop just continues the outer loop, so it
should be linear.
{quote}Maybe we only need one Factory
{quote}
I'm really seeing these as two separate filters, one for query time that
handles graphs, and one for index time that assumes a linear stream (or sausage
:)), so I think a single factory would confuse things. But we can discuss that
on the other issue, I think this is a simpler thing to get in first.
> Add a FixedShingleFilter
> ------------------------
>
> Key: LUCENE-8202
> URL: https://issues.apache.org/jira/browse/LUCENE-8202
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
> Attachments: LUCENE-8202.patch, LUCENE-8202.patch
>
>
> In LUCENE-3475 I tried to make a ShingleGraphFilter that could accept and
> emit arbitrary graphs, while duplicating all the functionality of the
> existing ShingleFilter. This ends up being extremely hairy, and doesn't play
> well with query parsers.
> I'd like to step back and try and create a simpler shingle filter that can be
> used for index-time phrase tokenization only. It will have a single fixed
> shingle size, can deal with single-token synonyms, and won't emit unigrams.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
