[
https://issues.apache.org/jira/browse/LUCENE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413012#comment-16413012
]
Karl Wright commented on LUCENE-8220:
-------------------------------------
[~ivera] Switchover code has been implemented and committed, and the tests
enabled.
The only remaining concerns are as follows:
(1) The API for makeGeoPolygon() accepts holes as other GeoPolygons. This is
incompatible with GeoComplexPolygon, so I've disabled the cutover in the case
where holes are present. The right thing to do in any case is create a new
variant of the makeGeoPolygon() method that accepts holes as a list of
PolygonDescription objects, and builds them itself. We'd want to deprecate the
old method also.
(2) It's also plausible now to automatically decide, based on number of points,
whether we want to cut over to GeoComplexPolygon based on polygon complexity.
We may want to implement a cutover automatically at (say) 100 points, just for
performance reasons.
> GeoPolygon factory still shows problems with coplanar points
> ------------------------------------------------------------
>
> Key: LUCENE-8220
> URL: https://issues.apache.org/jira/browse/LUCENE-8220
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Priority: Major
> Attachments: concave.jpg, concaveWithTiling.jpg,
> coplanarity-test.patch, factory.patch
>
>
> The attached patch contains two polygons that still shows problems with
> co-planar points. To better explain the issue I attached some images:
> 1) concave.jpg: This is the polygon we want to build. Note that we want to
> build the concave part, therefore the blue part is actually not part of the
> shape and the white part is the area cover by the shape.
> 2) concaveWithTiling.jpg: The algorithm of the polygon factory tries to tile
> the polygon using convex polygons. In our case it creates the three colored
> polygons on the image. What it remains is a concave polygon.
> The problem with this polygon is that the right edge of the concave polygon
> contains co-planar points. These points cannot be merged into a single plane
> because they have different properties (internal edges or shape edges).
> Because GeoConvexPolygon and GeoConcavePolygon cannot handle polygons with
> co-planar points, the polygon cannot be built.
> [~kwri...@metacarta.com], Is it possible to make this polygons support such
> an extreme case?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
