Hi,
I did not run smoke tester, but I checked some more fancy stuff to be safe: I
tried the JAR file (lucene-core.jar) with multiple Java versions and the MR-JAR
feature worked with a quick “hack” (it creates a broken BytesRef and calls a
method on it, the resulting Exception’s stack trace should have right methods):
*****************************************************
JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144
java version "1.8.0_144"
Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)
*****************************************************
Microsoft Windows [Version 10.0.16299.334]
(c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.
C:\Users\Uwe Schindler\Desktop\test>type Test.java
import org.apache.lucene.util.BytesRef;
public abstract class Test {
public static void main(String... args) {
BytesRef b1 = new BytesRef(new byte[0], 0, 10);
BytesRef b2 = new BytesRef(20);
b1.compareTo(b2);
}
}
C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0, 10)
out-of-bounds for length 0
at
org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)
at
org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)
at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
at Test.main(Test.java:7)
And now Java 9 / 10:
*****************************************************
JAVA_HOME = C:\Program Files\Java\jdk-9.0.1
java version "9.0.1"
Java(TM) SE Runtime Environment (build 9.0.1+11)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)
*****************************************************
C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
index out of range: 10
at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
at Test.main(Test.java:7)
*****************************************************
JAVA_HOME = C:\Program Files\Java\jdk-10
openjdk version "10" 2018-03-20
OpenJDK Runtime Environment 18.3 (build 10+46)
OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)
*****************************************************
C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
index out of range: 10
at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
at Test.main(Test.java:7)
So all looks fine from this perspective.
I then tested to start the techproducts example with Java 8, Java 9, Java 10:
Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows)
because of the braindead version parsing:
C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
I will open an issue to fix this (or better: let’s simply remove the version
check as it cannot be made safe with shell scripting).
**********************************************
So -1 to release if this also affects Linux (not yet tested).
**********************************************
Sorry,
Uwe
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
http://www.thetaphi.de <http://www.thetaphi.de/>
eMail: [email protected]
From: Alan Woodward <[email protected]>
Sent: Monday, March 26, 2018 4:06 PM
To: [email protected]
Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1
Please vote for release candidate 1 for Lucene/Solr 7.3.0
The artifacts can be downloaded from:
https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
You can run the smoke tester directly with this command:
python3 -u dev-tools/scripts/smokeTestRelease.py
https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
Here’s my +1
SUCCESS! [1:09:03.674472]
