[ 
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414667#comment-16414667
 ] 

Varun Thacker edited comment on SOLR-7887 at 3/26/18 10:33 PM:
---------------------------------------------------------------

[~koji] while upgrading log4j.properties for prometheus 
[https://github.com/apache/lucene-solr/blob/master/solr/contrib/prometheus-exporter/conf/log4j.properties]
 , I see that it only has a CONSOLE appender . Any reason why it doesn't have a 
default file based appender as well ? If you are fine I plan on using 
[https://github.com/apache/lucene-solr/blob/master/solr/server/resources/log4j2.xml]
 configuration for prometheus as well in my subsequent patch.

 

The second change I plan on making is while converting the log4j.properties 
from the test package to log4j2.xml use SYSTEM_ERR instead of SYSTEM_OUT ( what 
it uses currently )

The reason being all test packages today use SYSTEM_ERR ( 
[https://github.com/apache/lucene-solr/blob/branch_7_3/solr/solrj/src/test-files/log4j.properties#L5]
 for example ) and this seems to be the only package using SYSTEM_OUT .  Maybe 
it doesn't make a difference but atleast we'll standardize it


was (Author: varunthacker):
[~koji] while upgrading log4j.properties for prometheus 
[https://github.com/apache/lucene-solr/blob/master/solr/contrib/prometheus-exporter/conf/log4j.properties]
 , I see that it only has a CONSOLE appender . Any reason why it doesn't have a 
default file based appender as well ? If you are fine I plan on using 
[https://github.com/apache/lucene-solr/blob/master/solr/server/resources/log4j2.xml]
 configuration for prometheus as well in my subsequent patch.

> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
> ----------------------------------------------------------------
>
>                 Key: SOLR-7887
>                 URL: https://issues.apache.org/jira/browse/SOLR-7887
>             Project: Solr
>          Issue Type: Task
>            Reporter: Shawn Heisey
>            Assignee: Erick Erickson
>            Priority: Major
>             Fix For: 7.4
>
>         Attachments: SOLR-7887-WIP.patch, SOLR-7887-eoe-review.patch, 
> SOLR-7887-eoe-review.patch, SOLR-7887-followup_1.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887_followup_2.patch
>
>
> The logging services project has officially announced the EOL of log4j 1:
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> In the official binary jetty deployment, we use use log4j 1.2 as our final 
> logging destination, so the admin UI has a log watcher that actually uses 
> log4j and java.util.logging classes.  That will need to be extended to add 
> log4j2.  I think that might be the largest pain point to this upgrade.
> There is some crossover between log4j2 and slf4j.  Figuring out exactly which 
> jars need to be in the lib/ext directory will take some research.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to