[ https://issues.apache.org/jira/browse/LUCENE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058476#comment-13058476 ]
Michael McCandless commented on LUCENE-3272: -------------------------------------------- Big +1! We've needed query parsing factored out for a loooong time. And cutting tests over to a new MockQP, and then simply moving (but not merging) all QPs together to a module, sounds like great first steps. Note that the FieldType work (at least as currently planned/targetted) isn't a schema -- it's really just a nicer API for working with documents. Ie, nothing is persisted, nothing checks that 2 docs have the fields / types, etc. Still, it would be great to pull Solr's QP in and somehow abstract the parts that require access to Solr's schema. > Consolidate Lucene's QueryParsers into a module > ----------------------------------------------- > > Key: LUCENE-3272 > URL: https://issues.apache.org/jira/browse/LUCENE-3272 > Project: Lucene - Java > Issue Type: Improvement > Components: modules/queryparser > Reporter: Chris Male > > Lucene has a lot of QueryParsers and we should have them all in a single > consistent place. > The following are QueryParsers I can find that warrant moving to the new > module: > - Lucene Core's QueryParser > - AnalyzingQueryParser > - ComplexPhraseQueryParser > - ExtendableQueryParser > - Surround's QueryParser > - PrecedenceQueryParser > - StandardQueryParser > - XML-Query-Parser's CoreParser > All seem to do a good job at their kind of parsing with extensive tests. > One challenge of consolidating these is that many tests use Lucene Core's > QueryParser. One option is to just replicate this class in src/test and call > it TestingQueryParser. Another option is to convert all tests over to > programmatically building their queries (seems like alot of work). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org