On Wed, Mar 28, 2018 at 9:59 AM, Adrien Grand <[email protected]> wrote: > I'd > still be interested in other opinions regarding whether it would be ok to > rely more on ByteBufferGuard to have exceptions rather than segfaults when > reading closed index inputs given that comments say it is only a best > effort. >
I think that would be a mistake. this logic tries to reduce the window as much as possible, without impacting performance but it is not "correct" for multiple threads: it uses a regular 'boolean' variable. It is just a practical thing for now until there is a correct close() in java itself for this kind of thing that won't crash the VM. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
