[
https://issues.apache.org/jira/browse/SOLR-12065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420785#comment-16420785
]
Varun Thacker commented on SOLR-12065:
--------------------------------------
Hi Rohit,
Thanks for the patch. This looks great!
Some feedback from the patch:
1. In AbstractCloudBackupRestoreTestCase we added a new method
indexNewDocsToCollection . Can't we reuse indexDocs ? We can make changes to
that method so that it's generally more reusable for your test
Also in general we don't need to do \{{Random random = new Random(docsSeed);}}
. We can do \{{Random r = random();}} because the test setup already has a
static method to get random.
2. Maybe \{[getDocCountInCollection}} can be something like this since we are
counting the number of docs in a collection , so hitting any underlying node
will be fine
{code}
private long getDocCountInCollection(String collectionName) throws
SolrServerException, IOException {
return cluster.getSolrClient().query(collectionName, new
SolrQuery("*:*")).getResults().getNumFound();
}
{code}
3. RestoreCmd has a unused import. This will make \{{ant precommit}} fail
4. Should both of the log.info lines added to RestoreCmd be debug level? Also
can we use parameterized logging ?
5. After the REQUESTAPPLYUPDATES command is sent , shouldn't we validate the
response? So something like this
{code}
ocmh.processResponses(new NamedList(), shardHandler, true,
"REQUESTAPPLYUPDATES calls did not succeed", asyncId, requestMap);
{code}
> Restore replica always in buffering state
> -----------------------------------------
>
> Key: SOLR-12065
> URL: https://issues.apache.org/jira/browse/SOLR-12065
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Assignee: Varun Thacker
> Priority: Major
> Attachments: 12065.patch, 12605UTLogs.txt.zip, logs_and_metrics.zip,
> restore_snippet.log
>
>
> Steps to reproduce:
>
> -
> [http://localhost:8983/solr/admin/collections?action=CREATE&name=test_backup&numShards=1&nrtReplicas=1]
> - curl [http://127.0.0.1:8983/solr/test_backup/update?commit=true] -H
> 'Content-type:application/json' -d '
> [ \{"id" : "1"}
> ]'
> -
> [http://localhost:8983/solr/admin/collections?action=BACKUP&name=test_backup&collection=test_backup&location=/Users/varunthacker/backups]
> -
> [http://localhost:8983/solr/admin/collections?action=RESTORE&name=test_backup&location=/Users/varunthacker/backups&collection=test_restore]
> * curl [http://127.0.0.1:8983/solr/test_restore/update?commit=true] -H
> 'Content-type:application/json' -d '
> [
> {"id" : "2"}
> ]'
> * Snippet when you try adding a document
> {code:java}
> INFO - 2018-03-07 22:48:11.555; [c:test_restore s:shard1 r:core_node22
> x:test_restore_shard1_replica_n21]
> org.apache.solr.update.processor.DistributedUpdateProcessor; Ignoring commit
> while not ACTIVE - state: BUFFERING replay: false
> INFO - 2018-03-07 22:48:11.556; [c:test_restore s:shard1 r:core_node22
> x:test_restore_shard1_replica_n21]
> org.apache.solr.update.processor.LogUpdateProcessorFactory$LogUpdateProcessor;
> [test_restore_shard1_replica_n21] webapp=/solr path=/update
> params={commit=true}{add=[2 (1594320896973078528)],commit=} 0 4{code}
> * If you see "TLOG.state" from [http://localhost:8983/solr/admin/metrics]
> it's always 1 (BUFFERING)
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
