[ 
https://issues.apache.org/jira/browse/SOLR-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423500#comment-16423500
 ] 

Shalin Shekhar Mangar commented on SOLR-12172:
----------------------------------------------

[~tomasflobbe] -- I don't think we should introduce another thread(pool) just 
for this feature. We can use a method similar to updateWatchedCollection which 
checks if the new znode version is greater than the old one. This ensures that 
we replace the old collection props only if the new one is actually newer.

> Race condition in collection properties can cause invalid cache of properties
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-12172
>                 URL: https://issues.apache.org/jira/browse/SOLR-12172
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Tomás Fernández Löbbe
>            Priority: Minor
>             Fix For: 7.4, master (8.0)
>
>         Attachments: SOLR-12172.patch
>
>
> From: https://builds.apache.org/job/Lucene-Solr-BadApples-Tests-master/24
> {noformat}
> java.lang.AssertionError: Could not see value change after setting collection 
> property. Name: property2, current value: value2, expected value: newValue
>       at 
> __randomizedtesting.SeedInfo.seed([1BCE6473A2A5E68A:FD89A9BD30939A79]:0)
>       at org.junit.Assert.fail(Assert.java:93)
>       at 
> org.apache.solr.cloud.CollectionPropsTest.waitForValue(CollectionPropsTest.java:146)
>       at 
> org.apache.solr.cloud.CollectionPropsTest.testReadWriteCached(CollectionPropsTest.java:115){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to