[ 
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425998#comment-16425998
 ] 

Steve Rowe commented on SOLR-7887:
----------------------------------

I pulled out the yetus audience-annotations bits from the last patch on this 
issue that had them (from March 2nd), then tested that maven compilation worked 
with it, and that precommit was happy. All fine.

But something in the patch caught my eye:
{noformat}
diff --git a/lucene/common-build.xml b/lucene/common-build.xml
index 4fa59ac936..e13f09bd6d 100644
--- a/lucene/common-build.xml
+++ b/lucene/common-build.xml
@@ -187,7 +187,8 @@
   <property name="javadoc.noindex" value="true"/>
 
   <property name="javadoc.doclint.args" value="-Xdoclint:all 
-Xdoclint:-missing"/>
-  <property name="javac.doclint.args" value="-Xdoclint:all/protected 
-Xdoclint:-missing"/>
+  <!---proc:none was added because of LOG4J2-1925 / JDK-8186647 -->
+  <property name="javac.doclint.args" value="-Xdoclint:all/protected 
-Xdoclint:-missing -proc:none"/>
   
   <!-- Javadoc classpath -->
   <path id="javadoc.classpath">
{noformat}
This explains why Ant compilation works now (and didn't in earlier versions of 
the patch without this change): {{-proc:none}} turns off annotation processing, 
and the compilation failures are due to ZooKeeper's use of (Yetus) annotations.

So in [^SOLR-7887-fix-maven-compilation.patch] I added this arg to the 
\{{maven-compiler-plugin}} config, and now Maven compilation succeeds too.

I'll commit this patch shortly.

> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
> ----------------------------------------------------------------
>
>                 Key: SOLR-7887
>                 URL: https://issues.apache.org/jira/browse/SOLR-7887
>             Project: Solr
>          Issue Type: Task
>            Reporter: Shawn Heisey
>            Assignee: Erick Erickson
>            Priority: Major
>             Fix For: 7.4
>
>         Attachments: SOLR-7887-WIP.patch, SOLR-7887-eoe-review.patch, 
> SOLR-7887-eoe-review.patch, SOLR-7887-fix-maven-compilation.patch, 
> SOLR-7887-followup_1.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887_followup_2.patch, SOLR-7887_followup_2.patch
>
>
> The logging services project has officially announced the EOL of log4j 1:
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> In the official binary jetty deployment, we use use log4j 1.2 as our final 
> logging destination, so the admin UI has a log watcher that actually uses 
> log4j and java.util.logging classes.  That will need to be extended to add 
> log4j2.  I think that might be the largest pain point to this upgrade.
> There is some crossover between log4j2 and slf4j.  Figuring out exactly which 
> jars need to be in the lib/ext directory will take some research.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to