[
https://issues.apache.org/jira/browse/SOLR-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428579#comment-16428579
]
Jason Gerlowski commented on SOLR-12194:
----------------------------------------
1. I'm a little concerned that this API change makes basic-auth setup (a pretty
commonly used SolrClient feature) more arcane than it needs to be for users.
Say what you want about the warts surrounding {{set/getBasicAuth*}} but at
least the methods are easy for novice users to discover and use. Maybe I'm
missing some easy way to set up auth and debug it at runtime without these
getters/setters though.
2. If we're building basic-auth on top of HttpClientBuilderFactory, does it
make sense to remove the lucene.experimental designation on that interface?
> Deprecate SolrRequest#setBasicAuthCredentials
> ---------------------------------------------
>
> Key: SOLR-12194
> URL: https://issues.apache.org/jira/browse/SOLR-12194
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Reporter: Jan Høydahl
> Priority: Major
> Fix For: 7.4
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should deprecate these methods in {{SolrRequest}}:
> {code:java}
> public SolrRequest setBasicAuthCredentials(String user, String password)
> public String getBasicAuthPassword()
> public String getBasicAuthUser()
> {code}
> The only way forward will be using the ClientBuilderFactory.
> For 7.4 we should deprecate these, and for 8.0 (master) remove them. First we
> need to migrate some tests etc that uses the old methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
