The command that’s run is just “ant test” - see e.g. 
<https://builds.apache.org/job/PreCommit-SOLR-Build/44/artifact/out/patch-unit-solr_core.txt>.

Sysprop tests.badapples is true by default these days (SOLR-12028), which is 
why this is happening.  (FYI I’m not particularly fond of this decision.)

I’d argue that the scenario here is roughly the same as devs running precommit 
locally; why should the automated checker behave differently?

--
Steve
www.lucidworks.com

> On Apr 9, 2018, at 4:59 AM, Jan Høydahl <jan....@cominvent.com> wrote:
> 
> Hi,
> 
> Looks like the auto Patch validation tests run @BadApple tests?
> 
>> Failed junit tests  |  solr.cloud.TestLeaderElectionZkExpiry 
> 
> The test was bad-appled in March
> 
>> @Test
>> @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028";) // 
>> 17-Mar-2018
>> public void testLeaderElectionWithZkExpiry() throws Exception {
> Is this on purpose?
> 
> --
> Jan Høydahl, search solution architect
> Cominvent AS - www.cominvent.com
> 
>> 9. apr. 2018 kl. 07:26 skrev Lucene/Solr QA (JIRA) <j...@apache.org>:
>> 
>> 
>>    [ 
>> https://issues.apache.org/jira/browse/SOLR-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430036#comment-16430036
>>  ] 
>> 
>> Lucene/Solr QA commented on SOLR-9640:
>> --------------------------------------
>> 
>> | (x) *{color:red}-1 overall{color}* |
>> \\
>> \\
>> || Vote || Subsystem || Runtime || Comment ||
>> || || || || {color:brown} Prechecks {color} ||
>> | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  
>> 0m  0s{color} | {color:green} The patch appears to include 3 new or modified 
>> test files. {color} |
>> || || || || {color:brown} master Compile Tests {color} ||
>> | {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
>> 16s{color} | {color:green} master passed {color} |
>> || || || || {color:brown} Patch Compile Tests {color} ||
>> | {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
>> 13s{color} | {color:green} the patch passed {color} |
>> | {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
>> 13s{color} | {color:green} the patch passed {color} |
>> | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
>> {color:green}  1m  9s{color} | {color:green} the patch passed {color} |
>> | {color:red}-1{color} | {color:red} Check forbidden APIs {color} | 
>> {color:red}  1m  6s{color} | {color:red} Check forbidden APIs 
>> check-forbidden-apis failed {color} |
>> | {color:red}-1{color} | {color:red} Validate source patterns {color} | 
>> {color:red}  1m  6s{color} | {color:red} Check forbidden APIs 
>> check-forbidden-apis failed {color} |
>> || || || || {color:brown} Other Tests {color} ||
>> | {color:red}-1{color} | {color:red} unit {color} | {color:red} 53m 
>> 32s{color} | {color:red} core in the patch failed. {color} |
>> | {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
>> 19s{color} | {color:green} test-framework in the patch passed. {color} |
>> | {color:black}{color} | {color:black} {color} | {color:black} 56m 
>> 59s{color} | {color:black} {color} |
>> \\
>> \\
>> || Reason || Tests ||
>> | Failed junit tests | solr.cloud.TestLeaderElectionZkExpiry |
>> \\
>> \\
>> || Subsystem || Report/Notes ||
>> | JIRA Issue | SOLR-9640 |
>> | JIRA Patch URL | 
>> https://issues.apache.org/jira/secure/attachment/12917997/SOLR-9640.patch |
>> | Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
>> validatesourcepatterns  |
>> | uname | Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8 
>> 21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
>> | Build tool | ant |
>> | Personality | 
>> /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
>>  |
>> | git revision | master / 3530397 |
>> | ant | version: Apache Ant(TM) version 1.9.3 compiled on April 8 2014 |
>> | Default Java | 1.8.0_152 |
>> | Check forbidden APIs | 
>> https://builds.apache.org/job/PreCommit-SOLR-Build/44/artifact/out/patch-check-forbidden-apis-solr.txt
>>  |
>> | Validate source patterns | 
>> https://builds.apache.org/job/PreCommit-SOLR-Build/44/artifact/out/patch-check-forbidden-apis-solr.txt
>>  |
>> | unit | 
>> https://builds.apache.org/job/PreCommit-SOLR-Build/44/artifact/out/patch-unit-solr_core.txt
>>  |
>> |  Test Results | 
>> https://builds.apache.org/job/PreCommit-SOLR-Build/44/testReport/ |
>> | modules | C: solr solr/core solr/test-framework U: solr |
>> | Console output | 
>> https://builds.apache.org/job/PreCommit-SOLR-Build/44/console |
>> | Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |
>> 
>> 
>> This message was automatically generated.
>> 
>> 
>> 
>>> Support PKI authentication and SSL in standalone-mode master/slave auth 
>>> with local security.json
>>> ------------------------------------------------------------------------------------------------
>>> 
>>>                Key: SOLR-9640
>>>                URL: https://issues.apache.org/jira/browse/SOLR-9640
>>>            Project: Solr
>>>         Issue Type: New Feature
>>>     Security Level: Public(Default Security Level. Issues are Public) 
>>>         Components: security
>>>           Reporter: Jan Høydahl
>>>           Assignee: Jan Høydahl
>>>           Priority: Major
>>>             Labels: authentication, pki
>>>            Fix For: 7.4, master (8.0)
>>> 
>>>        Attachments: SOLR-9640.patch, SOLR-9640.patch, SOLR-9640.patch, 
>>> SOLR-9640.patch, SOLR-9640.patch, SOLR-9640.patch, SOLR-9640.patch, 
>>> SOLR-9640.patch
>>> 
>>>         Time Spent: 10m
>>> Remaining Estimate: 0h
>>> 
>>> While working with SOLR-9481 I managed to secure Solr standalone on a 
>>> single-node server. However, when adding 
>>> {{&shards=localhost:8081/solr/foo,localhost:8082/solr/foo}} to the request, 
>>> I get 401 error. This issue will fix PKI auth to work for standalone, which 
>>> should automatically make both sharding and master/slave index replication 
>>> work.
>> 
>> 
>> 
>> --
>> This message was sent by Atlassian JIRA
>> (v7.6.3#76005)
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to