[
https://issues.apache.org/jira/browse/SOLR-12065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434763#comment-16434763
]
Varun Thacker edited comment on SOLR-12065 at 4/12/18 12:39 AM:
----------------------------------------------------------------
{code:java}
for (Slice shard : restoreCollection.getSlices()) {
ocmh.waitForNewShard(restoreCollectionName, shard.getName());
}{code}
I don't think we need to explicitly do this in RestoreCmd. We call
createcollection command which internally wait's for the shard to become
active. So we are good here.
I removed this logging line
{code:java}
int numberOfActiveShards = restoreCollection.getActiveSlices().size();
log.info("Number of activeShards: " + numberOfActiveShards);{code}
Also in the test case I cleaned up how we are counting docs before and after
indexing
With the latest patch , the HDFS backup test fails quite regularly on my
machine.
here's what's happening:
* we add docs after the restore is complete
* call commit
* query to assert doc count. Now if the query hits a non-leader replica and
open searcher hasn't been executed on the replica then gives the old count and
the test fails
was (Author: varunthacker):
{code:java}
for (Slice shard : restoreCollection.getSlices()) {
ocmh.waitForNewShard(restoreCollectionName, shard.getName());
}{code}
I don't think we need to explicitly do this in RestoreCmd. We call
createcollection command which internally wait's for the shard to become
active. So we are good here.
I removed this logging line
{code:java}
int numberOfActiveShards = restoreCollection.getActiveSlices().size();
log.info("Number of activeShards: " + numberOfActiveShards);{code}
Also in the test case I cleaned up how we are counting docs before and after
indexing
With the latest patch , the HDFS backup test fails quite regularly on my
machine.
here's what's happening:
- we add docs after the restore is complete
- call commit
- query to assert doc count. Now if the query hits a non-leader replica and
open searcher hasn't been called the replica gives the old count
> Restore replica always in buffering state
> -----------------------------------------
>
> Key: SOLR-12065
> URL: https://issues.apache.org/jira/browse/SOLR-12065
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Assignee: Varun Thacker
> Priority: Major
> Attachments: 12065.patch, 12605UTLogs.txt.zip, SOLR-12065.patch,
> SOLR-12065.patch, logs_and_metrics.zip, restore_snippet.log
>
>
> Steps to reproduce:
>
> -
> [http://localhost:8983/solr/admin/collections?action=CREATE&name=test_backup&numShards=1&nrtReplicas=1]
> - curl [http://127.0.0.1:8983/solr/test_backup/update?commit=true] -H
> 'Content-type:application/json' -d '
> [ \{"id" : "1"}
> ]'
> -
> [http://localhost:8983/solr/admin/collections?action=BACKUP&name=test_backup&collection=test_backup&location=/Users/varunthacker/backups]
> -
> [http://localhost:8983/solr/admin/collections?action=RESTORE&name=test_backup&location=/Users/varunthacker/backups&collection=test_restore]
> * curl [http://127.0.0.1:8983/solr/test_restore/update?commit=true] -H
> 'Content-type:application/json' -d '
> [
> {"id" : "2"}
> ]'
> * Snippet when you try adding a document
> {code:java}
> INFO - 2018-03-07 22:48:11.555; [c:test_restore s:shard1 r:core_node22
> x:test_restore_shard1_replica_n21]
> org.apache.solr.update.processor.DistributedUpdateProcessor; Ignoring commit
> while not ACTIVE - state: BUFFERING replay: false
> INFO - 2018-03-07 22:48:11.556; [c:test_restore s:shard1 r:core_node22
> x:test_restore_shard1_replica_n21]
> org.apache.solr.update.processor.LogUpdateProcessorFactory$LogUpdateProcessor;
> [test_restore_shard1_replica_n21] webapp=/solr path=/update
> params={commit=true}{add=[2 (1594320896973078528)],commit=} 0 4{code}
> * If you see "TLOG.state" from [http://localhost:8983/solr/admin/metrics]
> it's always 1 (BUFFERING)
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
