[ 
https://issues.apache.org/jira/browse/LUCENE-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435757#comment-16435757
 ] 

Adrien Grand commented on LUCENE-8249:
--------------------------------------

I don't like mixing scorers, which are about documents with matches which are 
about positions. This change is making the same class responsible for iterating 
over both documents and positions. Even if this might look ok today, I don't 
like that future refactorings about the scorer will have to worry about keeping 
this class working for positions or vice-versa. To be clear I'm not against 
sharing code between the scorer and the matches iterator, only having the same 
class doing both.

> Add matches to exact PhraseQuery and MultiPhraseQuery
> -----------------------------------------------------
>
>                 Key: LUCENE-8249
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8249
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>         Attachments: LUCENE-8249.patch
>
>
> ExactPhraseScorer can be rejigged fairly easily to expose a MatchesIterator



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to