[
https://issues.apache.org/jira/browse/LUCENE-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436716#comment-16436716
]
Lucene/Solr QA commented on LUCENE-8248:
----------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
7s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
7s{color} | {color:red} test-framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
7s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
8s{color} | {color:red} test-framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 7s{color}
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 7s{color}
| {color:red} test-framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 7s{color}
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 8s{color}
| {color:red} test-framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}
0m 7s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}
0m 7s{color} | {color:red} test-framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}
0m 7s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}
0m 8s{color} | {color:red} test-framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}
0m 7s{color} | {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} |
{color:red} 0m 7s{color} | {color:red} core in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 6s{color}
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 7s{color}
| {color:red} test-framework in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 7s{color}
| {color:red} core in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 8s{color}
| {color:red} test-framework in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 2m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8248 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918825/LUCENE-8248.2.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 0014f3a |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 8 2015 |
| Default Java | 1.8.0_152 |
| compile |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-lucene_core.txt
|
| compile |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-lucene_test-framework.txt
|
| compile |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-solr_core.txt
|
| compile |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-solr_test-framework.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-lucene_core.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-lucene_test-framework.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-solr_core.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-solr_test-framework.txt
|
| Release audit (RAT) |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-lucene_core.txt
|
| Release audit (RAT) |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-lucene_test-framework.txt
|
| Release audit (RAT) |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-solr_core.txt
|
| Release audit (RAT) |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-solr_test-framework.txt
|
| Check forbidden APIs |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-lucene_core.txt
|
| Validate source patterns |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-compile-lucene_core.txt
|
| unit |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-unit-lucene_core.txt
|
| unit |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-unit-lucene_test-framework.txt
|
| unit |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-unit-solr_core.txt
|
| unit |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/artifact/out/patch-unit-solr_test-framework.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/testReport/ |
| modules | C: lucene/core lucene/test-framework solr/core solr/test-framework
U: . |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/11/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Rename MergePolicyWrapper to FilterMergePolicy and override all of MergePolicy
> ------------------------------------------------------------------------------
>
> Key: LUCENE-8248
> URL: https://issues.apache.org/jira/browse/LUCENE-8248
> Project: Lucene - Core
> Issue Type: Wish
> Components: core/index
> Reporter: Mike Sokolov
> Priority: Minor
> Attachments: LUCENE-8248.1.patch, LUCENE-8248.2.patch,
> LUCENE-8248.patch, MergePolicy.patch
>
>
> MergePolicy.getMaxCFSSegmentSizeMB is final, but the corresponding setter is
> not, which means that overriding it with anything other than a trivial
> delegation can only lead to confusion.
> The patch makes the method final and removes the trivial implementations from
> MergePolicyWrapper and NoMergePolicy.
> [~mikemccand] also pointed out that the class name is nonstandard for similar
> adapter classes in Lucene, which are usually Filter*.java. Personally I was
> looking for MergePolicyAdapter, but if there is a prevailing convention here
> around Filter, does it make sense to change this class's name to
> FilterMergePolicy?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
