[ 
https://issues.apache.org/jira/browse/LUCENE-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436971#comment-16436971
 ] 

ASF subversion and git services commented on LUCENE-8233:
---------------------------------------------------------

Commit b8248d8fd67ad1071a77595bb0bd69ea13cf9030 in lucene-solr's branch 
refs/heads/branch_7x from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b8248d8 ]

LUCENE-8233: Never reset initiazlized DV gen

We drop changes after we finish a merge, this has also reset
the DV generation the PendingSoftDeletes were initialized on causing
assertions to trip if releaseing the reader was writing DV to disk.
This change removes resetting the dv generation to make assertions
hold which requried to keep the pending change count on PendingSoftDeletes.


>  Add support for soft deletes to IndexWriter delete accounting
> --------------------------------------------------------------
>
>                 Key: LUCENE-8233
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8233
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: LUCENE-8232.patch, LUCENE-8233.patch, LUCENE-8233.patch, 
> LUCENE-8233.patch
>
>
> This change adds support for soft deletes as a fully supported feature by the 
> index writer. Soft deletes are accounted for inside the index writer and 
> therefor also by merge policies.
>     
> This change also adds a SoftDeletesRetentionMergePolicy that allows users to 
> selectively carry over soft_deleted document across merges for retention 
> policies. The merge policy selects documents that should be kept around in 
> the merged segment based on a user provided query.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to