[ 
https://issues.apache.org/jira/browse/SOLR-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438007#comment-16438007
 ] 

Varun Thacker commented on SOLR-7736:
-------------------------------------

{code:java}
log.warn("Interrupted");{code}
Should we make this a little more descriptive : like "Exiting 
OverseerTriggerThread" ?

Should we break when we catch this InterruptedException?
{code:java}
try {
  refreshAutoScalingConf(new AutoScalingWatcher());
} catch (ConnectException e) {
  log.warn("ZooKeeper watch triggered for autoscaling conf, but Solr cannot 
talk to ZK: [{}]", e.getMessage());
} catch (InterruptedException e) {
  // Restore the interrupted status
  Thread.currentThread().interrupt();
  log.warn("Interrupted", e);
}{code}
 

> Add a test for ZkController.publishAndWaitForDownStates
> -------------------------------------------------------
>
>                 Key: SOLR-7736
>                 URL: https://issues.apache.org/jira/browse/SOLR-7736
>             Project: Solr
>          Issue Type: Test
>          Components: SolrCloud, Tests
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 7.4, master (8.0)
>
>         Attachments: SOLR-7736.patch, SOLR-7736.patch, 
> ZkController.failure.txt, consoleFull-2462-ZkControllerTest.txt.gz
>
>
> Add a test for ZkController.publishAndWaitForDownStates so that bugs like 
> SOLR-6665 do not occur again. A test exists but it is not correct and 
> currently disabled via AwaitsFix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to