GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/lucene-solr/pull/354
Change the method identifier from "getShardNames" to "addShardNames".
The method seems to add "sliceName" to "shardNames", thus the method name
"addShardNames" should be better "getShardNames" since "get" means getting
something.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BruceKuiLiu/lucene-solr getShardNames
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/354.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #354
----
commit 5f1da7b29f6171a6f83133443c461b396ff84803
Author: Kui LIU <brucekuiliu@...>
Date: 2018-04-17T13:02:10Z
Change the method identifier from "getShardNames" to "addShardNames".
The method seems to add "sliceName" to "shardNames", thus the method name
"addShardNames" should be better "getShardNames" since "get" means getting
something.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
