Dawid Weiss created LUCENE-8261:
-----------------------------------

             Summary: InterpolatedProperties.interpolate should quote the 
replacement
                 Key: LUCENE-8261
                 URL: https://issues.apache.org/jira/browse/LUCENE-8261
             Project: Lucene - Core
          Issue Type: Bug
            Reporter: Dawid Weiss
            Assignee: Dawid Weiss


InterpolatedProperties is used in lib check tasks in the build file. I 
occasionally see this:
{code}
/home/jenkins/workspace/Lucene-Solr-master-Linux/lucene/tools/custom-tasks.xml:108:
 java.lang.IllegalArgumentException: named capturing group is missing trailing 
'}'
        at 
java.base/java.util.regex.Matcher.appendExpandedReplacement(Matcher.java:1052)
        at java.base/java.util.regex.Matcher.appendReplacement(Matcher.java:908)
        at 
org.apache.lucene.dependencies.InterpolatedProperties.interpolate(InterpolatedProperties.java:64)
{code}

I don't think we ever need to use any group references in those replacements; 
they should be fixed strings (quoted verbatim)? So {{Pattern.quoteReplacement}} 
would be adequate here.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to