[
https://issues.apache.org/jira/browse/SOLR-12251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445884#comment-16445884
]
Shawn Heisey commented on SOLR-12251:
-------------------------------------
The patch also removes wildcard imports and makes a few formatting adjustments.
I looked at all usages of HashMap as well as HashSet in DocBuilder and
adjusted one of the HashMap usages to LinkedHashMap.
In the JdbcDataSource class, there were a couple of warnings from my IDE about
unnecessary else clauses, so I adjusted those too, and removed the wildcard
imports found there. (I was looking at JdbcDataSource to confirm which class
would log SQL statements, if that became necessary)
I've looked into the arguments on both sides of the debate on wildcard versus
specific imports. I think the potential problems with wildcard imports far
outweigh any level of convenience for somebody who wants to avoid hand-typing a
lot of import statements.
> pk ids not sort when in deltaQuery
> -----------------------------------
>
> Key: SOLR-12251
> URL: https://issues.apache.org/jira/browse/SOLR-12251
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - DataImportHandler
> Affects Versions: 7.1
> Environment: windows10
> Solr7.1
> JDK8
>
> Reporter: wzhonggo
> Priority: Major
> Attachments: SOLR-12251.patch
>
>
> I use solr and mysql for search.
>
> {code:xml}
> // data-config.xml
> query="select * from score order by create_date asc"
> deltaImportQuery="select * from score where id='${dih.delta.id}'"
> deltaQuery="selectid from score where update_date >
> '${dataimporter.last_index_time}' order by create_date asc "
> {code}
>
> Mysql has three rows data in *score* table
>
> ||id||name||score||create_date||update_date||
> |UUID1|user1|60|2018-04-10|2018-04-10|
> |UUID2|user1|70|2018-04-11 |2018-04-11|
> |UUID3|user1|80|2018-04-12|2018-04-12|
> The expected results In solr doc
> ||Name||Score||CreateDate||UpdateDate||
> |user1|80|2018-04-12|2018-04-12|
>
> Use full import it will correct , but use delta import will wrong.
> In the *org.apache.solr.handler.dataimport.DocBuilder* class , return not
> LinkHashSet in
> *collectDelta* method.
>
> Thanks.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
