precommit: BUILD SUCCESSFUL Total time: 10 minutes 48 seconds
on a my like 2 year old macbook pro I think that is reasonable? On Thu, Apr 26, 2018 at 3:23 PM, Karl Wright <daddy...@gmail.com> wrote: > :-) > > 25 minutes is an eternity these days, Robert. This is especially true when > others are collaborating with what you are doing, as was the case here. The > other approach would be to create a branch, but I've been avoiding that on > git. > > "ant documentation-lint" is what I'm looking for, thanks. > > Karl > > > On Thu, Apr 26, 2018 at 8:21 AM, Robert Muir <rcm...@gmail.com> wrote: >> >> I don't understand the turnaround issue, why do the commits need to be >> rushed in? >> There is patch validation recently hooked in to avoid keeping your >> computer busy for 25 minutes. >> If you are not changing third party dependencies or anything "heavy" >> like that you should at least run "ant documentation-lint" from >> lucene/ >> >> >> On Thu, Apr 26, 2018 at 8:02 AM, Karl Wright <daddy...@gmail.com> wrote: >> > How long does precommit take you to run? For me, it's a good 25 >> > minutes. >> > That really impacts turnaround, which is why I'd love a precommit that >> > looked only at certain things in the local package I'm dealing with. >> > >> > Karl >> > >> > On Thu, Apr 26, 2018 at 6:14 AM, Simon Willnauer >> > <simon.willna...@gmail.com> >> > wrote: >> >> >> >> Hey folks, >> >> >> >> I had to fix several glitches lately that are caught by running >> >> precommit. It's a simple step please take the time running `ant clean >> >> precommit` on top-level. >> >> >> >> Thanks, >> >> >> >> Simon >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
