[ https://issues.apache.org/jira/browse/LUCENE-8277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454401#comment-16454401 ]
Adrien Grand commented on LUCENE-8277: -------------------------------------- Here is an example of what I had in mind. SegmentMerger runs CheckIndex with slow checks disabled on readers that do not implement SegmentReader. > Better validate CodecReaders in addIndexes > ------------------------------------------ > > Key: LUCENE-8277 > URL: https://issues.apache.org/jira/browse/LUCENE-8277 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Priority: Minor > Attachments: LUCENE-8277.patch > > > The discussion at LUCENE-8264 made me wonder that we should apply the same > checks to addIndexes(CodecReader) that we apply at index time if the input > reader is not a SegmentReader such as: > - positions are less than the maximum position > - offsets are going forward > And maybe also check that the API is implemented correctly, eg. terms, doc > ids and positions are returned in order? -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org