[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456587#comment-16456587
]
David Smiley commented on SOLR-11865:
-------------------------------------
_I deleted my previous comment as I did it from an old/wrong account
accidentally._
I said:
{quote}Maybe we should make it a query param, which is more convenient &
useful. The spots that load the config that examine this boolean could track
the order (e.g. using LinkedHashSet) even if ultimately the order might not be
needed? It seems like not a big deal to track the order potentially needlessly
but you might have a better sense of this.
{quote}
You said:
{quote}Actually the TrieSubsetMatcher introduced by the next patch does not
support keepElevationPriority.
{quote}
Well I think it's okay to have another parameter that is ignored if another
parameter is set. This would still be the case even if it wasn't a runtime
parameter! (it's just a matter of where it's specified)
In general, Solr has been trying to use more runtime parameters where possible
& appropriate to avoid the requirement to modify configs. It's good for
experimentation, and makes tests easier to write (no new config file to put in
the tests).
> Refactor QueryElevationComponent to prepare query subset matching
> -----------------------------------------------------------------
>
> Key: SOLR-11865
> URL: https://issues.apache.org/jira/browse/SOLR-11865
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SearchComponents - other
> Affects Versions: master (8.0)
> Reporter: Bruno Roustant
> Priority: Minor
> Labels: QueryComponent
> Fix For: master (8.0)
>
> Attachments:
> 0001-Refactor-QueryElevationComponent-to-introduce-Elevat.patch,
> 0002-Refactor-QueryElevationComponent-after-review.patch,
> 0003-Remove-exception-handlers-and-refactor-getBoostDocs.patch,
> SOLR-11865.patch
>
>
> The goal is to prepare a second improvement to support query terms subset
> matching or query elevation rules.
> Before that, we need to refactor the QueryElevationComponent. We make it
> extendible. We introduce the ElevationProvider interface which will be
> implemented later in a second patch to support subset matching. The current
> full-query match policy becomes a default simple MapElevationProvider.
> - Add overridable methods to handle exceptions during the component
> initialization.
> - Add overridable methods to provide the default values for config properties.
> - No functional change beyond refactoring.
> - Adapt unit test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
