[
https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458106#comment-16458106
]
Mark Miller commented on SOLR-12290:
------------------------------------
Looks like this may actually have been fixed during some refactoring at some
point. I found this in an older code base and saw we still close these streams,
but at some point we started shielding the response writer close at a higher
level. I originally put in those close shields, but had missed shielding the
response writing properly. I think when HttpSolrCall came about, this ended up
getting shielded.
So I'll remove these closes and review our shielding and testing. It seems a
little error prone right now and I think we can do better.
> When you fetch a file for replication we close the request output stream
> after writing the file which ruins the connection for reuse.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-12290
> URL: https://issues.apache.org/jira/browse/SOLR-12290
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Major
>
> We can't close response output streams, we need to reuse these connections.
> If we do, clients are hit will connection problems when they try and reuse
> the connection from their pool.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
