[ 
https://issues.apache.org/jira/browse/SOLR-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458617#comment-16458617
 ] 

David Smiley commented on SOLR-12278:
-------------------------------------

+1 overall.  
 * probably won't pass precommit; I see {{<ul}} dangling in the javadocs of 
ObjectSizeEstimator
 * it'd be nice if the exception thrown included the units "KB" with the size 
of the document
 * fastEstimate ought to iterate a Map using the entryset with for-each style 
to avoid double-lookup when the value is needed

> Ignore very large document on indexing
> --------------------------------------
>
>                 Key: SOLR-12278
>                 URL: https://issues.apache.org/jira/browse/SOLR-12278
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Cao Manh Dat
>            Assignee: Cao Manh Dat
>            Priority: Major
>         Attachments: SOLR-12278.patch, SOLR-12278.patch
>
>
> Solr should be able to ignore very large document, so it won't affect the 
> index as well as the tlog. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to