[
https://issues.apache.org/jira/browse/LUCENE-8287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-8287:
-------------------------------------
Description:
When an empty RegexCompletionQuery is provided to ContextQuery, the following
assertion failure occurs:
{code:java}
java.lang.AssertionError: input should not end with the context separator
at
org.apache.lucene.search.suggest.document.ContextQuery$ContextCompletionWeight.setInnerWeight(ContextQuery.java:296)
at
org.apache.lucene.search.suggest.document.ContextQuery$ContextCompletionWeight.setNextMatch(ContextQuery.java:275)
at
org.apache.lucene.search.suggest.document.NRTSuggester.lookup(NRTSuggester.java:221)
at
org.apache.lucene.search.suggest.document.CompletionScorer.score(CompletionScorer.java:70)
at org.apache.lucene.search.BulkScorer.score(BulkScorer.java:39)
at
org.apache.lucene.search.suggest.document.SuggestIndexSearcher.suggest(SuggestIndexSearcher.java:78)
at
org.apache.lucene.search.suggest.document.SuggestIndexSearcher.suggest(SuggestIndexSearcher.java:58)
at
org.apache.lucene.search.suggest.document.TestContextQuery.testEmptyRegexQuery(TestContextQuery.java:193)
{code}
This is a bit of an edge case, but may be concerning since without assertions
enabled, you can go on to access IntsRef indices that are out of bounds.
The attached patch provides a reproduction of the issue, as the test case
TestContextQuery#testEmptyRegexQuery. Note that to reproduce, Java assertions
must be enabled (as in the default configuration for tests).
The patch also provides a test case for the normal behavior of an empty
RegexCompletionQuery, when it is not wrapped in ContextQuery
(TestRegexCompletionQuery#testEmptyRegexQuery). In this case, there is no
error, and all suggestions are returned.
was:
When an empty RegexCompletionQuery is provided to ContextQuery, the following
assertion failure occurs:
{code:java}
java.lang.AssertionError: input should not end with the context separator
at
org.apache.lucene.search.suggest.document.ContextQuery$ContextCompletionWeight.setInnerWeight(ContextQuery.java:296)
at
org.apache.lucene.search.suggest.document.ContextQuery$ContextCompletionWeight.setNextMatch(ContextQuery.java:275)
at
org.apache.lucene.search.suggest.document.NRTSuggester.lookup(NRTSuggester.java:221)
at
org.apache.lucene.search.suggest.document.CompletionScorer.score(CompletionScorer.java:70)
at org.apache.lucene.search.BulkScorer.score(BulkScorer.java:39)
at
org.apache.lucene.search.suggest.document.SuggestIndexSearcher.suggest(SuggestIndexSearcher.java:78)
at
org.apache.lucene.search.suggest.document.SuggestIndexSearcher.suggest(SuggestIndexSearcher.java:58)
at
org.apache.lucene.search.suggest.document.TestContextQuery.testEmptyRegexQuery(TestContextQuery.java:193)
{code}
This is a bit of an edge case, but may be concerning as without assertions
enabled, you can go on to access IntsRef indices that are out of bounds.
The attached patch provides a reproduction of the issue, as the test case
TestContextQuery#testEmptyRegexQuery. Note that to reproduce, Java assertions
must be enabled (as in the default configuration for tests).
The patch also provides a test case for the normal behavior of an empty
RegexCompletionQuery, when it is not wrapped in ContextQuery
(TestRegexCompletionQuery#testEmptyRegexQuery). In this case, there is no
error, and all suggestions are returned.
> ContextQuery with empty RegexCompletionQuery produces an assertion failure
> --------------------------------------------------------------------------
>
> Key: LUCENE-8287
> URL: https://issues.apache.org/jira/browse/LUCENE-8287
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Julie Tibshirani
> Priority: Major
> Attachments: LUCENE-8287-repro.patch
>
>
> When an empty RegexCompletionQuery is provided to ContextQuery, the following
> assertion failure occurs:
> {code:java}
> java.lang.AssertionError: input should not end with the context separator
> at
> org.apache.lucene.search.suggest.document.ContextQuery$ContextCompletionWeight.setInnerWeight(ContextQuery.java:296)
> at
> org.apache.lucene.search.suggest.document.ContextQuery$ContextCompletionWeight.setNextMatch(ContextQuery.java:275)
> at
> org.apache.lucene.search.suggest.document.NRTSuggester.lookup(NRTSuggester.java:221)
> at
> org.apache.lucene.search.suggest.document.CompletionScorer.score(CompletionScorer.java:70)
> at org.apache.lucene.search.BulkScorer.score(BulkScorer.java:39)
> at
> org.apache.lucene.search.suggest.document.SuggestIndexSearcher.suggest(SuggestIndexSearcher.java:78)
> at
> org.apache.lucene.search.suggest.document.SuggestIndexSearcher.suggest(SuggestIndexSearcher.java:58)
> at
> org.apache.lucene.search.suggest.document.TestContextQuery.testEmptyRegexQuery(TestContextQuery.java:193)
> {code}
> This is a bit of an edge case, but may be concerning since without assertions
> enabled, you can go on to access IntsRef indices that are out of bounds.
> The attached patch provides a reproduction of the issue, as the test case
> TestContextQuery#testEmptyRegexQuery. Note that to reproduce, Java assertions
> must be enabled (as in the default configuration for tests).
> The patch also provides a test case for the normal behavior of an empty
> RegexCompletionQuery, when it is not wrapped in ContextQuery
> (TestRegexCompletionQuery#testEmptyRegexQuery). In this case, there is no
> error, and all suggestions are returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
