[
https://issues.apache.org/jira/browse/LUCENE-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463532#comment-16463532
]
Simon Willnauer commented on LUCENE-8295:
-----------------------------------------
{noformat}
Not that I fully understand it, but looking at the patch alone wouldn't it miss
calling pendingDeletes.liveDocsShared() (and this in turn does have further
consequences in that other class)? Ping Simon, he'll know.
{noformat}
I looked at the history and I agree with [~jpountz] that this is unnecessary to
do outside of the places where we call it explicitly ie in getReaderForMerge
and getReadOnlyClone. patch LGTM
> Remove ReadersAndUpdates.liveDocsSharedPending
> ----------------------------------------------
>
> Key: LUCENE-8295
> URL: https://issues.apache.org/jira/browse/LUCENE-8295
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-8295.patch
>
>
> I have been trying to undersdand PendingDeletes and ReadersAndUpdates, and it
> looks to me that the liveDocsSharedPending flag doesn't buy anything. I ran
> tests 10 times after removing it and got no failures.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
