[
https://issues.apache.org/jira/browse/SOLR-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Male updated SOLR-2027:
-----------------------------
Attachment: SOLR-2027.patch
Patch which fixes the problem and adds a trivial test to prevent regression.
Ready to go.
> SolrJ FacetField should never return null from getValues()
> ----------------------------------------------------------
>
> Key: SOLR-2027
> URL: https://issues.apache.org/jira/browse/SOLR-2027
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Affects Versions: 1.4.1
> Reporter: David Smiley
> Assignee: Chris Male
> Priority: Minor
> Attachments: SOLR-2027.patch
>
>
> In some circumstances, FacetField.getValues() will return null. I'd like for
> my iteration code to simply be:
> {code:java}
> for (c : ff.getValues() {
> // ...
> }
> {code}
> However this will throw an NPE if I don't wrap this in either a null check or
> this check: ff.getValueCount() > 0
> I propose that getValues() return a Collections.EMPTY_LIST if the internal
> value is null.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
