[ 
https://issues.apache.org/jira/browse/SOLR-12320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466535#comment-16466535
 ] 

Mark Miller commented on SOLR-12320:
------------------------------------

I will have to investigate some to be sure of much, but as far as I know, we 
currently write to a tmp file due to a File based implementation we pick from 
commons-fileupload.

If Tika writes to a different temp file anyway, maybe it's as simple as 
changing that implementation, I'm not sure yet.

We do currently clean up using this reaper thread class that we have copied 
from commons-fileupload due to needing some customizations. I really don't like 
it though - if we could do cleanup without a reaper thread always running in 
the background that would be great - or if we didn't need to write to a tmp 
file here at all. I don't know if we can avoid it entirely or not though. The 
only thing I could think of that might count on it is uploading very large 
files for tika to parse with Solr Cell.

> Not all multi-part post requests should create tmp files.
> ---------------------------------------------------------
>
>                 Key: SOLR-12320
>                 URL: https://issues.apache.org/jira/browse/SOLR-12320
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>
> We create tmp files for multi-part posts because often they are uploaded 
> files for Solr cell or something but we also sometimes write params only or 
> params and updates as multi-part post. These should not create any tmp files.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to