[ https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468161#comment-16468161 ]
Robert Muir commented on LUCENE-7960: ------------------------------------- Also for the full ctor that allows a range, i really still think it needs some wording, a warning of sorts, that a big range is really the same (space/time-wise) as indexing the content N different ways. It may be also good to include the fact that if you pass {{true}} for preserveOriginal, its like indexing the content yet another time. The ctor that just takes a fixed "n" for the n-gram doesn't need such warnings, its pretty safe. > NGram filters -- preserve the original token when it is outside the min/max > size range > -------------------------------------------------------------------------------------- > > Key: LUCENE-7960 > URL: https://issues.apache.org/jira/browse/LUCENE-7960 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/analysis > Reporter: Shawn Heisey > Priority: Major > Attachments: LUCENE-7960.patch, LUCENE-7960.patch, LUCENE-7960.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > When ngram or edgengram filters are used, any terms that are shorter than the > minGramSize are completely removed from the token stream. > This is probably 100% what was intended, but I've seen it cause a lot of > problems for users. I am not suggesting that the default behavior be > changed. That would be far too disruptive to the existing user base. > I do think there should be a new boolean option, with a name like > keepShortTerms, that defaults to false, to allow the short terms to be > preserved. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org