Github user pgerber commented on the issue:
https://github.com/apache/lucene-solr/pull/374
> fileKey is implemented on windows, so its untrue that nothing would
change.
Looking at the [OpenJDK 10 source
code](http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/777356696811/src/java.base/windows/classes/sun/nio/fs/WindowsFileAttributes.java#l417),
keyFile returns null invariably on Windows. Unless I'm wrong about it
returning null on Windows, there should indeed not be any change. (I don't have
Windows, so I couldn't actually test it.)
> in general, the problem is with the metadata on gluster. lockfactory gets
picked on because its the first thing you will hit (that's its job!), but
hacking around the problem for gluster won't really help you. Its problems go
much deeper, e.g. rename() isn't atomic. Its not appropriate for lucene indexes.
So I've noticed and we'll probably move away from Gluster before long.
However, I'd still like to see this change merged, independent of any issues
with Gluster. To me, it would appear to be more sensible to use a natively by
Java supported way for uniquely identifying files on platforms that support it
as opposed to a hack using file creation/modification timestamps.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
