[ https://issues.apache.org/jira/browse/LUCENE-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472261#comment-16472261 ]
Robert Muir commented on LUCENE-8308: ------------------------------------- also maybe terminally deprecate KeywordRepeatFilter, i mean I doubt we can preserve compat here 100%: that is what major versions are for. If there was an "else" condition it would make it very easy on the user to migrate. > migrate KeywordRepeatFilter to conditional tokenstreams > ------------------------------------------------------- > > Key: LUCENE-8308 > URL: https://issues.apache.org/jira/browse/LUCENE-8308 > Project: Lucene - Core > Issue Type: Task > Components: modules/analysis > Reporter: Robert Muir > Priority: Major > > we should deprecate KeywordAttribute in favor of LUCENE-8273 which gives the > analysis chain a real "if". > But this isn't straightforward unless we address the KeywordRepeatFilter > which sends the token "both ways" down the branch condition. Maybe it can be > handled as a subclass. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org