[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476383#comment-16476383
]
Ingomar Wesp edited comment on LUCENE-7960 at 5/15/18 7:40 PM:
---------------------------------------------------------------
Sorry for not responding earlier*. Looks good to me; however, the logic can be
simplified further, now that we don't care about differentiating between the
two cases anymore. Unless someone else wants to address this and Robert's
other suggestions, I would like to further refine the patch and submit a new
one this weekend.
*) Even though I'm watching this issue, I'm not getting mails from Jira. Is
this intentional for non-commiters?
was (Author: iwesp):
Sorry for not responding earlier*. Looks good to me; however, the logic can be
simplified further, now that we don't care about differentiating between the
two cases anymore. Unless someone else wants to address this and Robert's
other suggestions, I would like to further refine the patch and submit a new
one this weekend.
*) Even though I'm watching this issue, I'm not getting mails from Jira. Is
this intentional for non-commiters?
> NGram filters -- preserve the original token when it is outside the min/max
> size range
> --------------------------------------------------------------------------------------
>
> Key: LUCENE-7960
> URL: https://issues.apache.org/jira/browse/LUCENE-7960
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Shawn Heisey
> Priority: Major
> Attachments: LUCENE-7960.patch, LUCENE-7960.patch, LUCENE-7960.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When ngram or edgengram filters are used, any terms that are shorter than the
> minGramSize are completely removed from the token stream.
> This is probably 100% what was intended, but I've seen it cause a lot of
> problems for users. I am not suggesting that the default behavior be
> changed. That would be far too disruptive to the existing user base.
> I do think there should be a new boolean option, with a name like
> keepShortTerms, that defaults to false, to allow the short terms to be
> preserved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
