This is one of those topics that generates far more passion than it deserves, all I want to know is what the norms are. Personally, I tend to reformat the entire file. But then I didn't cut my eye teeth on code that a zillion other people work with and I fully appreciate that the diffs get hard to read, you can't easily separate the code changes from the format changes, so I'm not *proposing* reformatting the whole file...
So do we take a page from Martin Fowler's "Refactoring" book and only reformat the parts that we're working on? What about reformatting the whole file and noting in the checkin notes "reformat only, no code changes"? (assuming an egregiously badly-formatted file that one is working on). I guess the more I think about it the more sense only reformatting the bits we're working on makes. I'd guess that someone working on a large patch would...er...not appreciate merge conflicts because of reformatting even though it's soooo easy.... Again, I'm just looking for norms here. I suspect this topic has been...er...discussed upon occasion in loud tones with much table pounding... Thanks, Erick P.S. This is relative to my first checkin, SOLR-2535 --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
