[ 
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479563#comment-16479563
 ] 

Christine Poerschke commented on LUCENE-7788:
---------------------------------------------

bq. 3> Since we're going through the review in the first place we can 
regularize the names of the loggers to whatever we want. It looks like "log" is 
the least number of changes so it wins by default. WDYT about adding a 
precommit check for that too?

+1 to regularizing logger names. SOLR-12372 gives it a go starting with (part 
of) {{solr/contrib}} and looking at the patch made me wonder/question how 
conversion to unparameterised logging would best work with (a) long log 
messages e.g.
{code}
         log
             .warn(
                 "Could not instantiate Lucene stemmer for Arabic, clustering 
quality "
                     + "of Arabic content may be degraded. For best quality 
clusters, "
                     + "make sure Lucene's Arabic analyzer JAR is in the 
classpath",
                 e);
{code}
and (b) exceptions e.g.
{code}
         log.warn("Could not instantiate snowball stemmer"
             + " for language: " + language.name()
             + ". Quality of clustering may be degraded.", e);
{code}
scenarios?

> fail precommit on unparameterised log.trace messages
> ----------------------------------------------------
>
>                 Key: LUCENE-7788
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7788
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: LUCENE-7788.patch, LUCENE-7788.patch
>
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use 
> and once that is in place then this ticket's one-line change would be for 
> 'ant precommit' to reject any future unparameterised log.trace message use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to