Thank you very much! i will update the patch name and open a Pull Request with the correct Jira issue key! Thank you again, this is definitely a start!
Cheers -------------------------- Alessandro Benedetti Search Consultant, R&D Software Engineer, Director www.sease.io On Tue, May 22, 2018 at 1:29 PM, Robert Muir <[email protected]> wrote: > > > On Tue, May 22, 2018 at 7:03 AM, Alessandro Benedetti < > [email protected]> wrote: > >> Hi Robert, >> thanks for the feedback. >> I read your comment last year and you I agreed completely. >> So I started step by step, with the refactor first. >> >> The first contribution is isolating a part of the refactor, so no >> functional change in the algorithms nor a complete refactor in place. >> I basically tried to decompose the refactor is unitary pull requests as >> small as possible. >> It just focused on the MLT parameters first to reduce the size of the >> original MoreLikeThis class ( and relegating the parameter modelling >> responsibility to a separate class) >> >> https://issues.apache.org/jira/browse/SOLR-12299 >> >> The reason I used SOLR is because the refactor affects some Solr >> components using the MLT. >> But I agree with you, it can (should) be moved to LUCENE ( I tried via >> JIRA but I don't think I have the right permissions). >> >> Should I just create a new JIRA issue completely ( closing the SOLR one) >> or some JIRA admin can directly move the Jira to the LUCENE project ? >> >> > I moved it: https://issues.apache.org/jira/browse/LUCENE-8326 > >
