[
https://issues.apache.org/jira/browse/LUCENE-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489567#comment-16489567
]
Michael McCandless commented on LUCENE-8330:
--------------------------------------------
+1, this is awesome!
{quote}removes the directory comparison which is a relict from old
addIndices(Directory[]) impls _I think?!_ .
{quote}
I think that was in fact its purpose so it's safe to remove now since we've
changed how {{addIndexes(Directory[])}} works.
{quote}now the segString impls will be not showing live-deletes. I am not sure
it's very important. [~mikemccand] WDYT?
{quote}
Seeing the live deletes has been really helpful in the past, but I agree it's
an awkward addition on the interface, so +1 to keep it out.
policies -> policy's in:
{quote}and change during the execution of a merge policies selection processes.
{quote}
I like the {{MockMergeContext}} in the new test case.
> Detach IndexWriter from MergePolicy
> -----------------------------------
>
> Key: LUCENE-8330
> URL: https://issues.apache.org/jira/browse/LUCENE-8330
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 7.4, master (8.0)
> Reporter: Simon Willnauer
> Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: LUCENE-8330.patch, LUCENE-8330.patch, LUCENE-8330.patch
>
>
> This change introduces a new MergePolicy.MergeContext interface
> that is easy to mock and cuts over all instances of IW to MergeContext.
> Since IW now implements MergeContext the cut over is straight forward.
> This reduces the exposed API available in MP dramatically and allows
> efficient testing without relying on IW to improve the coverage and
> testability of our MP implementations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
