[
https://issues.apache.org/jira/browse/SOLR-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489658#comment-16489658
]
Christine Poerschke commented on SOLR-12395:
--------------------------------------------
bq. Why not use the constant everywhere?
Yes, that would be a possibility too whilst in this code area.
And we could potentially also add a backwards compatibility test -- ShardParams
has
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.3.1/solr/solrj/src/test/org/apache/solr/common/params/ShardParamsTest.java#L21-L27
for example.
> Typo in SignificantTermsQParserPlugin.NAME
> ------------------------------------------
>
> Key: SOLR-12395
> URL: https://issues.apache.org/jira/browse/SOLR-12395
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: query parsers
> Affects Versions: 6.5, 7.3.1
> Reporter: Tobias Kässmann
> Priority: Trivial
> Attachments: SOLR-12395.patch
>
>
> I think there is a small typo in the {{SignificantTermsQParserPlugin}}:
> {code:java}
> public static final String NAME = "sigificantTerms";{code}
> should be:
> {code:java}
> public static final String NAME = "significantTerms";{code}
> See the patch attached.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
