Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/384#discussion_r191568572
--- Diff:
lucene/suggest/src/java/org/apache/lucene/search/suggest/document/NRTSuggesterBuilder.java
---
@@ -43,6 +44,9 @@
* in the output
*/
public static final int PAYLOAD_SEP = '\u001F';
+ static {
+ assert PAYLOAD_SEP == ConcatenateGraphFilter.SEP_CHAR;
--- End diff --
I think it's useful to read the code and both see what's it's value is and
that it's equal to something else without having to navigate or use IDE
functions. But this is no big deal to me; I can put back. Presumably if these
values were not the same then some a test would fail but I'm not sure.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
