[ 
https://issues.apache.org/jira/browse/SOLR-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496774#comment-16496774
 ] 

Mikhail Khludnev edited comment on SOLR-5211 at 5/31/18 4:08 PM:
-----------------------------------------------------------------

This what we discussed at Vegas, [~hossman]. Let's treat all docs (even 
childfree) parents. Here are pros, and cons:
(+)  mixing parents and childfree (not yet in tests)
(+)  overwriting childfree by parent (in tests)
(-) for those who run childfree-only index its waste index space for storing 
useless {{\_root_}} column, as a workaround they can enable {{<updateHandler 
class="solr.LegacyDirectUpdateHandler">}} (I'm not happy about this name). 
* atomic updates for parents is not there but just possible

I'd like to tweak the tests a little. Meanwhile, the questions are: 
- Are we going this way? 
- what release strategy is worth to take? eg make {{ParentAlwaysDUH2}} optional 
in 7.4. but default in 8.0 or turn it by default right now 




was (Author: mkhludnev):
This what we discussed at Vegas, [~hossman]. Let's treat all docs (even 
childfree) parents. Here are pros, and cons:
(+)  mixing parents and childfree (not yet in tests)
(+)  overwriting childfree by parent (in tests)
(-) for those who run childfree-only index its waste index space for storing 
useless {{\_root_}} column, as a workaround they can enable {{ <updateHandler 
class="solr.LegacyDirectUpdateHandler">}} (I'm not happy about this name). 
* atomic updates for parents is not there but just possible

I'd like to tweak the tests a little. Meanwhile, the questions are: 
- Are we going this way? 
- what release strategy is worth to take? eg make {{ParentAlwaysDUH2}} optional 
in 7.4. but default in 8.0 or turn it by default right now 



> updating parent as childless makes old children orphans
> -------------------------------------------------------
>
>                 Key: SOLR-5211
>                 URL: https://issues.apache.org/jira/browse/SOLR-5211
>             Project: Solr
>          Issue Type: Sub-task
>          Components: update
>    Affects Versions: 4.5, 6.0
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>            Priority: Major
>         Attachments: SOLR-5211.patch
>
>
> if I have parent with children in the index, I can send update omitting 
> children. as a result old children become orphaned. 
> I suppose separate \_root_ fields makes much trouble. I propose to extend 
> notion of uniqueKey, and let it spans across blocks that makes updates 
> unambiguous.  
> WDYT? Do you like to see a test proves this issue?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to