[
https://issues.apache.org/jira/browse/SOLR-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497876#comment-16497876
]
Jason Gerlowski commented on SOLR-12194:
----------------------------------------
bq. A way to improve this could be for SolrRequest to store a set of generic
HTTPHeaders instead of basicAuthUser/Pass. We could provide status utility
methods to add header for BasicAuth as well as other kinds of headers.
That goes a long way towards my addressing concerns about keeping the API
intuitive for novice users, especially if a {{setBasicAuthCredentials}} sugar
method is retained on {{SolrRequest}}. It also seems to address Hoss's
concerns about sharing a SolrClient across many users, at least as I understand
them. I'll let him speak to that himself though.
> Deprecate SolrRequest#setBasicAuthCredentials
> ---------------------------------------------
>
> Key: SOLR-12194
> URL: https://issues.apache.org/jira/browse/SOLR-12194
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrJ
> Reporter: Jan Høydahl
> Priority: Major
> Fix For: 7.4
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should deprecate these methods in {{SolrRequest}}:
> {code:java}
> public SolrRequest setBasicAuthCredentials(String user, String password)
> public String getBasicAuthPassword()
> public String getBasicAuthUser()
> {code}
> The only way forward will be using the ClientBuilderFactory.
> For 7.4 we should deprecate these, and for 8.0 (master) remove them. First we
> need to migrate some tests etc that uses the old methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
