[
https://issues.apache.org/jira/browse/LUCENE-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063249#comment-13063249
]
Simon Willnauer edited comment on LUCENE-3296 at 7/11/11 9:54 AM:
------------------------------------------------------------------
here is a new patch. I added a second IWC since we can not reuse IWC instances
across IW due to SetOnce restrictions. I also moved out the VERSION_CURRENT and
made it a ctor argument. We should not randomly use the VERSION_CURRENT but
rather be consistent when we use version.
bq. Simon: The Version.LUCENE_CURRENT is not important here, for easier
porting, the version should be LUCENE_CURRENT (and it was before Jason's
patch). Else we will have to always upgrade it with every new release. The same
applies to the IndexUpdater class in core, it also uses LUCENE_CURRENT when you
not pass in anything (as the version is completely useless for simple merge
operations - like here).
not entirely true, we use the index splitter in 3.x and if you upgrade from 3.1
to 3.2 you get a new mergepolicy by default which doesn't merge in order. I
think its a problem that this version is not in 3.x yet so let fix it properly
and backport.
Simon
was (Author: simonw):
here is a new patch. I added a second IWC since we can not reuse IWC
instances across IW due to SetOnce restrictions. I also moved out the
VERSION_CURRENT and made it a ctor argument. We should not randomly use the
VERSION_CURRENT but rather be consistent when we use version.
> Enable passing a config into PKIndexSplitter
> --------------------------------------------
>
> Key: LUCENE-3296
> URL: https://issues.apache.org/jira/browse/LUCENE-3296
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/other
> Affects Versions: 3.3, 4.0
> Reporter: Jason Rutherglen
> Assignee: Simon Willnauer
> Priority: Trivial
> Attachments: LUCENE-3296.patch, LUCENE-3296.patch, LUCENE-3296.patch
>
>
> I need to be able to pass the IndexWriterConfig into the IW used by
> PKIndexSplitter.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
