Github user moshebla commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/385#discussion_r192579604
  
    --- Diff: 
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java ---
    @@ -417,7 +417,8 @@ private void addAndDelete(AddUpdateCommand cmd, 
List<UpdateLog.DBQ> deletesAfter
       }
     
       private Term getIdTerm(AddUpdateCommand cmd) {
    --- End diff --
    
    After looking at the code, it seems like updateDocOrDocValues has to return 
the idTerm to be used by the caller, and the updateTerm can then be figured out 
by the caller, either the cmd.updateTerm or the idTerm.
    I will push a commit soon, hopefully the code can do the talking.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to