[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500922#comment-16500922 ]
Jim Ferenczi commented on LUCENE-8344: -------------------------------------- The exact match pass filters prefix paths that don't end with END_BYTE so we'd have to change it to ignore trailing POS_SEPs (line 709 and 727). Though we have no way to infer the value of preservePositionIncrements for an indexed suggestion so I am not even sure that we can handle the BWC safely. Considering that re-build should be trivial in the AnalyzingSuggester, we could simply consider the fix a breaking change and discuss if it's acceptable to backport to 7x ? > TokenStreamToAutomaton doesn't ignore trailing posInc when > preservePositionIncrements=false > ------------------------------------------------------------------------------------------- > > Key: LUCENE-8344 > URL: https://issues.apache.org/jira/browse/LUCENE-8344 > Project: Lucene - Core > Issue Type: Bug > Components: modules/suggest > Reporter: David Smiley > Priority: Major > Attachments: LUCENE-8344.patch, LUCENE-8344.patch > > > TokenStreamToAutomaton in Lucene core is used by the AnalyzingSuggester > (incl. FuzzySuggester subclass ) and NRT Document Suggester and soon the > SolrTextTagger. It has a setting {{preservePositionIncrements}} defaulting > to true. If it's set to false (e.g. to ignore stopwords) and if there is a > _trailing_ position increment greater than 1, TS2A will _still_ add position > increments (holes) into the automata even though it was configured not to. > I'm filing this issue separate from LUCENE-8332 where I first found it. The > fix is very simple but I'm concerned about back-compat ramifications so I'm > filing it separately. I'll attach a patch to show the problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org