[ 
https://issues.apache.org/jira/browse/SOLR-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063418#comment-13063418
 ] 

Yonik Seeley commented on SOLR-2452:
------------------------------------

The script produced output like this:

{code}
Index: solr/core/src/java/org/apache/solr/core/SolrCore.java
===================================================================
--- solr/src/java/org/apache/solr/core/SolrCore.java    (revision 
888880231429dc9c7680375a0a21b1886e59b194)
+++ solr/src/java/org/apache/solr/core/SolrCore.java    (revision )
{code}

Notice that "core" wasn't substituted on the lines starting with --- and +++

Trying to use the resulting patch file, I got:
{code}
/opt/code/lusolr$ patch -p0 < tt.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: solr/core/src/java/org/apache/solr/core/SolrCore.java
|===================================================================
|--- solr/src/java/org/apache/solr/core/SolrCore.java   (revision 
888880231429dc9c7680375a0a21b1886e59b194)
|+++ solr/src/java/org/apache/solr/core/SolrCore.java   (revision )
--------------------------
{code}

> rewrite solr build system
> -------------------------
>
>                 Key: SOLR-2452
>                 URL: https://issues.apache.org/jira/browse/SOLR-2452
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>            Assignee: Steven Rowe
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2452-post-reshuffling.patch, 
> SOLR-2452-post-reshuffling.patch, SOLR-2452-post-reshuffling.patch, 
> SOLR-2452.diffSource.py.patch.zip, SOLR-2452.dir.reshuffle.sh, 
> SOLR-2452.dir.reshuffle.sh, SOLR-2452.patch.hack.pl
>
>
> As discussed some in SOLR-2002 (but that issue is long and hard to follow), I 
> think we should rewrite the solr build system.
> Its slow, cumbersome, and messy, and makes it hard for us to improve things.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to