[
https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503705#comment-16503705
]
Alessandro Benedetti commented on LUCENE-8326:
----------------------------------------------
I just attached a revised patch and Pull Request :
1) impact on user side has been considerably reduced keeping getters and
setters in the MLT main class and parameters in the external class
2) Parameters with defaults have their own class, making them easy to maintain
and read, it will be easy to pass them to inner MLT modules when the refactor
continues
3) Boost logic is still away from users of the MLT, this keeps the
responsibility of managing boost, MLT side, open to discuss this
4) the patch is built on top of SOLR-12304 bugfix, that should go IN first
anyway
Happy to revise further, if necessary and follow up with the following
refactors ( in separate Jira issues)
> More Like This Params Refactor
> ------------------------------
>
> Key: LUCENE-8326
> URL: https://issues.apache.org/jira/browse/LUCENE-8326
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/query/scoring
> Reporter: Alessandro Benedetti
> Priority: Major
> Attachments: LUCENE-8326.patch, LUCENE-8326.patch, LUCENE-8326.patch,
> LUCENE-8326.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> More Like This ca be refactored to improve the code readability, test
> coverage and maintenance.
> Scope of this Jira issue is to start the More Like This refactor from the
> More Like This Params.
> This Jira will not improve the current More Like This but just keep the same
> functionality with a refactored code.
> Other Jira issues will follow improving the overall code readability, test
> coverage and maintenance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
