[
https://issues.apache.org/jira/browse/SOLR-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506268#comment-16506268
]
David Smiley commented on SOLR-5265:
------------------------------------
[~varunthacker] can you explain why you removed equals/hashCode from
SolrDocument (today, it'd be SolrDocumentBase)? (related to SOLR-6048). It's
not obvious writing tests that equals() should not be used nor that
{{SolrTestCaseJ4.compareSolrInputDocument}} exists. Furthermore,
SolrDocumentBase implements Map and Map spells out equals & hashCode semantics
that we don't comply with (we don't meet base class demands). Sure we _get
away with it_ but.... :-/
> Add backward compatibility tests to JavaBinCodec's format.
> ----------------------------------------------------------
>
> Key: SOLR-5265
> URL: https://issues.apache.org/jira/browse/SOLR-5265
> Project: Solr
> Issue Type: Test
> Reporter: Adrien Grand
> Assignee: Noble Paul
> Priority: Blocker
> Fix For: 4.8, 6.0
>
> Attachments: SOLR-5265.patch, SOLR-5265.patch, SOLR-5265.patch,
> SOLR-5265.patch, javabin_backcompat.bin
>
>
> Since Solr guarantees backward compatibility of JavaBinCodec's format between
> releases, we should have tests for it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
