[
https://issues.apache.org/jira/browse/SOLR-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507990#comment-16507990
]
Andrzej Bialecki commented on SOLR-12208:
------------------------------------------
This looks good. Minor issue: {{Suggestion.metricsAttrSuffix}} is a confusing
name in the context of this class - it's used as a suffix in
{{SolrClientNodeStateProvider}} but IMHO it should have a name that reflects
what it really is, eg. {{metricName}} and makes sense also in other contexts.
> Don't use "INDEX.sizeInBytes" as a tag name in policy calculations
> ------------------------------------------------------------------
>
> Key: SOLR-12208
> URL: https://issues.apache.org/jira/browse/SOLR-12208
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling
> Reporter: Andrzej Bialecki
> Assignee: Noble Paul
> Priority: Major
> Attachments: SOLR-12208.patch
>
>
> CORE_IDX and FREEDISK ConditionType reuse this metric name, but they assume
> the values are expressed in gigabytes. This alone is confusing considering
> the name of the metric.
> Additionally, it causes conflicts in the simulation framework that would
> require substantial changes to resolve (ReplicaInfo-s in
> SimClusterStateProvider keep metric values in their variables, expressed in
> original units - but then the Policy assumes it can put the values expressed
> in GB under the same key... hilarity ensues).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
