> +1 to remove via; who actually pushed the change is (or should be) > unimportant,
I don't care much for credit and am pretty much indifferent to any of these options. The way I see it is that 'via' is not much of a credit but a *responsibility* -- the committer should have reviewed the change she or he is contributing on behalf of the non-committer. Sure, git history is fine too but note that it's not ideal -- it may not mention the actual contributor of a patch if it's a manual application of a diff file and in cases like this it'd require more complex processing than just scanning through CHANGES.txt.... so I'd opt for simplicity of keeping it together in CHANGES.txt (easier to scan through, doesn't take any credit away from the author), but I'll live with any decision. Dawid --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
