[
https://issues.apache.org/jira/browse/SOLR-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512909#comment-16512909
]
Steve Rowe commented on SOLR-12362:
-----------------------------------
Reproducing {{TestJsonRecordReader}} failures, from Yetus on SOLR-12395
[https://builds.apache.org/job/PreCommit-SOLR-Build/123/artifact/out/patch-unit-solr_solrj.txt],
which {{git bisect}} blames on the {{21fe416}} master commit on this issue:
{noformat}
[junit4] Suite: org.apache.solr.common.util.TestJsonRecordReader
[junit4] 2> Creating dataDir:
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/solr/build/solr-solrj/test/J1/temp/solr.common.util.TestJsonRecordReader_9BC2BA48D076310E-001/init-core-data-001
[junit4] 2> 783465 INFO
(SUITE-TestJsonRecordReader-seed#[9BC2BA48D076310E]-worker) [ ]
o.a.s.SolrTestCaseJ4 Using PointFields (NUMERIC_POINTS_SYSPROP=true)
w/NUMERIC_DOCVALUES_SYSPROP=false
[junit4] 2> 783466 INFO
(SUITE-TestJsonRecordReader-seed#[9BC2BA48D076310E]-worker) [ ]
o.a.s.SolrTestCaseJ4 Randomized ssl (false) and clientAuth (false) via:
@org.apache.solr.util.RandomizeSSL(reason=, ssl=NaN, value=NaN, clientAuth=NaN)
[junit4] 2> 783466 INFO
(SUITE-TestJsonRecordReader-seed#[9BC2BA48D076310E]-worker) [ ]
o.a.s.SolrTestCaseJ4 SecureRandom sanity checks:
test.solr.allowed.securerandom=null & java.security.egd=file:/dev/./urandom
[junit4] 2> 783517 INFO
(TEST-TestJsonRecordReader.testOneLevelSplit-seed#[9BC2BA48D076310E]) [ ]
o.a.s.SolrTestCaseJ4 ###Starting testOneLevelSplit
[junit4] 2> 783555 INFO
(TEST-TestJsonRecordReader.testOneLevelSplit-seed#[9BC2BA48D076310E]) [ ]
o.a.s.SolrTestCaseJ4 ###Ending testOneLevelSplit
[junit4] 2> 783556 INFO
(TEST-TestJsonRecordReader.testRecursiveWildcard2-seed#[9BC2BA48D076310E]) [
] o.a.s.SolrTestCaseJ4 ###Starting testRecursiveWildcard2
[junit4] 2> 783557 INFO
(TEST-TestJsonRecordReader.testRecursiveWildcard2-seed#[9BC2BA48D076310E]) [
] o.a.s.SolrTestCaseJ4 ###Ending testRecursiveWildcard2
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestJsonRecordReader -Dtests.method=testRecursiveWildcard2
-Dtests.seed=9BC2BA48D076310E -Dtests.multiplier=2 -Dtests.slow=true
-Dtests.badapples=true -Dtests.locale=mt -Dtests.timezone=America/Jujuy
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
[junit4] FAILURE 0.06s J1 | TestJsonRecordReader.testRecursiveWildcard2 <<<
[junit4] > Throwable #1: java.lang.AssertionError: expected:<6> but
was:<7>
[junit4] > at
__randomizedtesting.SeedInfo.seed([9BC2BA48D076310E:CA96D19E65F5AA5B]:0)
[junit4] > at
org.apache.solr.common.util.TestJsonRecordReader.testRecursiveWildcard2(TestJsonRecordReader.java:253)
[junit4] > at java.lang.Thread.run(Thread.java:748)
[junit4] 2> 783612 INFO
(TEST-TestJsonRecordReader.testNestedJsonWithFloats-seed#[9BC2BA48D076310E]) [
] o.a.s.SolrTestCaseJ4 ###Starting testNestedJsonWithFloats
[junit4] 2> 783612 INFO
(TEST-TestJsonRecordReader.testNestedJsonWithFloats-seed#[9BC2BA48D076310E]) [
] o.a.s.SolrTestCaseJ4 ###Ending testNestedJsonWithFloats
[junit4] 2> 783613 INFO
(TEST-TestJsonRecordReader.testRecursiveWildCard-seed#[9BC2BA48D076310E]) [
] o.a.s.SolrTestCaseJ4 ###Starting testRecursiveWildCard
[junit4] 2> 783614 INFO
(TEST-TestJsonRecordReader.testRecursiveWildCard-seed#[9BC2BA48D076310E]) [
] o.a.s.SolrTestCaseJ4 ###Ending testRecursiveWildCard
[junit4] 2> 783700 INFO
(TEST-TestJsonRecordReader.testSrcField-seed#[9BC2BA48D076310E]) [ ]
o.a.s.SolrTestCaseJ4 ###Starting testSrcField
[junit4] 2> 783759 INFO
(TEST-TestJsonRecordReader.testSrcField-seed#[9BC2BA48D076310E]) [ ]
o.a.s.SolrTestCaseJ4 ###Ending testSrcField
[junit4] 2> 783846 INFO
(TEST-TestJsonRecordReader.testArrayOfRootObjects-seed#[9BC2BA48D076310E]) [
] o.a.s.SolrTestCaseJ4 ###Starting testArrayOfRootObjects
[junit4] 2> 786590 INFO
(TEST-TestJsonRecordReader.testArrayOfRootObjects-seed#[9BC2BA48D076310E]) [
] o.a.s.SolrTestCaseJ4 ###Ending testArrayOfRootObjects
[junit4] 2> 786676 INFO
(TEST-TestJsonRecordReader.testClearPreviousRecordFields-seed#[9BC2BA48D076310E])
[ ] o.a.s.SolrTestCaseJ4 ###Starting testClearPreviousRecordFields
[junit4] 2> 786677 INFO
(TEST-TestJsonRecordReader.testClearPreviousRecordFields-seed#[9BC2BA48D076310E])
[ ] o.a.s.SolrTestCaseJ4 ###Ending testClearPreviousRecordFields
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestJsonRecordReader -Dtests.method=testClearPreviousRecordFields
-Dtests.seed=9BC2BA48D076310E -Dtests.multiplier=2 -Dtests.slow=true
-Dtests.badapples=true -Dtests.locale=mt -Dtests.timezone=America/Jujuy
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
[junit4] FAILURE 0.09s J1 |
TestJsonRecordReader.testClearPreviousRecordFields <<<
[junit4] > Throwable #1: java.lang.AssertionError
[junit4] > at
__randomizedtesting.SeedInfo.seed([9BC2BA48D076310E:A51705718E0A9F18]:0)
[junit4] > at
org.apache.solr.common.util.TestJsonRecordReader.testClearPreviousRecordFields(TestJsonRecordReader.java:364)
[junit4] > at java.lang.Thread.run(Thread.java:748)
[junit4] 2> 786678 INFO
(TEST-TestJsonRecordReader.testAIOOBE-seed#[9BC2BA48D076310E]) [ ]
o.a.s.SolrTestCaseJ4 ###Starting testAIOOBE
[junit4] 2> 786718 INFO
(TEST-TestJsonRecordReader.testAIOOBE-seed#[9BC2BA48D076310E]) [ ]
o.a.s.SolrTestCaseJ4 ###Ending testAIOOBE
[junit4] 2> 786720 INFO
(TEST-TestJsonRecordReader.testNestedDocs-seed#[9BC2BA48D076310E]) [ ]
o.a.s.SolrTestCaseJ4 ###Starting testNestedDocs
[junit4] 2> 786721 INFO
(TEST-TestJsonRecordReader.testNestedDocs-seed#[9BC2BA48D076310E]) [ ]
o.a.s.SolrTestCaseJ4 ###Ending testNestedDocs
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestJsonRecordReader -Dtests.method=testNestedDocs
-Dtests.seed=9BC2BA48D076310E -Dtests.multiplier=2 -Dtests.slow=true
-Dtests.badapples=true -Dtests.locale=mt -Dtests.timezone=America/Jujuy
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
[junit4] ERROR 0.00s J1 | TestJsonRecordReader.testNestedDocs <<<
[junit4] > Throwable #1: java.lang.NullPointerException
[junit4] > at
__randomizedtesting.SeedInfo.seed([9BC2BA48D076310E:D96EA7A37187345E]:0)
[junit4] > at
org.apache.solr.common.util.TestJsonRecordReader.lambda$testNestedDocs$0(TestJsonRecordReader.java:284)
[junit4] > at
org.apache.solr.common.util.JsonRecordReader$Node.handleObjectStart(JsonRecordReader.java:383)
[junit4] > at
org.apache.solr.common.util.JsonRecordReader$Node.parse(JsonRecordReader.java:291)
[junit4] > at
org.apache.solr.common.util.JsonRecordReader$Node.access$200(JsonRecordReader.java:155)
[junit4] > at
org.apache.solr.common.util.JsonRecordReader.streamRecords(JsonRecordReader.java:140)
[junit4] > at
org.apache.solr.common.util.JsonRecordReader.streamRecords(JsonRecordReader.java:136)
[junit4] > at
org.apache.solr.common.util.TestJsonRecordReader.testNestedDocs(TestJsonRecordReader.java:282)
[junit4] > at java.lang.Thread.run(Thread.java:748)
[junit4] 2> NOTE: leaving temporary files on disk at:
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/solr/build/solr-solrj/test/J1/temp/solr.common.util.TestJsonRecordReader_9BC2BA48D076310E-001
[junit4] 2> NOTE: test params are: codec=Asserting(Lucene70): {},
docValues:{}, maxPointsInLeafNode=381, maxMBSortInHeap=6.536094904375801,
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@3f50c672),
locale=mt, timezone=America/Jujuy
[junit4] 2> NOTE: Linux 4.4.0-112-generic amd64/Oracle Corporation
1.8.0_172 (64-bit)/cpus=4,threads=1,free=427902360,total=492306432
{noformat}
> JSON loader should save the relationship of children
> ----------------------------------------------------
>
> Key: SOLR-12362
> URL: https://issues.apache.org/jira/browse/SOLR-12362
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: mosh
> Assignee: David Smiley
> Priority: Major
> Fix For: 7.5
>
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Once _childDocuments in SolrInputDocument is changed to a Map, JsonLoader
> should add the child document to the map while saving its key name, to
> maintain the child's relationship to its parent.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
